Skip to content

[WebProfilerBundle] Fix the design of the compact toolbar button #53225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2023
Merged

[WebProfilerBundle] Fix the design of the compact toolbar button #53225

merged 1 commit into from
Dec 27, 2023

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

This continues #52769. The bug was in 6.3 and newer versions, not in 5.4.

This is how the compact toolbar looks in dark mode:

before

And this is the same after this PR:

after

@javiereguiluz javiereguiluz added this to the 6.3 milestone Dec 27, 2023
@javiereguiluz javiereguiluz mentioned this pull request Dec 27, 2023
Closed
@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit 83ee0ea into symfony:6.3 Dec 27, 2023
@javiereguiluz javiereguiluz deleted the fix_toolbar_compact branch December 27, 2023 09:52
This was referenced Dec 30, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @nicolas-grekas @carsonbot