[Notifier] [OneSignal] Add support for sending to external user ids #53262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Dec 28, 2023
src/Symfony/Component/Notifier/Bridge/OneSignal/Tests/OneSignalTransportTest.php
Outdated
Show resolved
Hide resolved
33ec1c0 to
149d25d
Compare
OskarStark
reviewed
Dec 28, 2023
OskarStark
reviewed
Dec 28, 2023
src/Symfony/Component/Notifier/Bridge/OneSignal/OneSignalTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
requested changes
Dec 28, 2023
149d25d to
533a831
Compare
OskarStark
approved these changes
Dec 29, 2023
|
Thank you @KDederichs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #53248, here's the feature PR against 7.1.
This introduces a new
isExternalUserId()option to indicate that the receiver is an external user id.At the same time it also replaces the deprecated
include_player_idsoption.