Skip to content

Add missing PHPDoc type #53391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add missing PHPDoc type #53391

wants to merge 2 commits into from

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues --
License MIT

Follows

@OskarStark OskarStark requested a review from chalasr as a code owner January 3, 2024 13:58
@carsonbot carsonbot added this to the 7.1 milestone Jan 3, 2024
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark OskarStark mentioned this pull request Jan 3, 2024
Merged
@OskarStark OskarStark changed the base branch from 7.1 to 6.3 January 3, 2024 18:01
@OskarStark OskarStark modified the milestones: 7.1, 6.3 Jan 3, 2024
@OskarStark
Copy link
Contributor Author

I consider fabbot as false positive

@nicolas-grekas
Copy link
Member

Should be closed for the reason give at #53363 (comment) I suppose.

@OskarStark
Copy link
Contributor Author

Ok then 🤷‍♂️

@OskarStark OskarStark deleted the fix/doc-6.3 branch January 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @carsonbot @nicolas-grekas