Skip to content

[ErrorHandler] remove not needed PHP version check #53469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

[ErrorHandler] remove not needed PHP version check #53469

merged 1 commit into from
Jan 9, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 9, 2024

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from yceruto as a code owner January 9, 2024 10:57
@carsonbot carsonbot added this to the 6.3 milestone Jan 9, 2024
GromNaN
GromNaN reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an other one:

symfony/src/Symfony/Component/HttpClient/Internal/CurlClientState.php

Line 98 in 9bd2814

if (\defined('CURL_LOCK_DATA_CONNECT') && \PHP_VERSION_ID >= 80000) {

@xabbuh
Copy link
Member Author

xabbuh commented Jan 9, 2024

There are a few more that are not necessary. I didn't remove them intentionally as they have been there for quite some time. This one is different because it was just added recently in #53006 and can be removed after merging 5.4 into 6.3.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit d55add4 into symfony:6.3 Jan 9, 2024
@xabbuh xabbuh deleted the pr-53006 branch January 9, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
ErrorHandler Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @GromNaN @carsonbot