[FrameworkBundle] [CacheWarmer] Run ConfigBuilderCacheWarmer during execution of bin/console cache:warmup
#53512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.3, 6.4, or 7.0 for bug fixes". Cheers! Carsonbot |
ConfigBuilderCacheWarmer during execution of bin/console cache:warmupConfigBuilderCacheWarmer during execution of bin/console cache:warmup
|
I'm proposing #53672 instead, can you please give it a try? |
|
Thanks for submitting. Please let me know if you're still having the issue. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 29, 2024
…-optional (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] `ConfigBuilderCacheWarmer` should be non-optional | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53496 | License | MIT Replaces #53512 This became apparent after #50391, where the warmer is run only when compiling the container. Before, it didn't really matter. Commits ------- 8bd2ff8 [FrameworkBundle] ConfigBuilderCacheWarmer should be non-optional
|
Yes, now it works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigBuilderCacheWarmeris not called when executingbin/console cache:warmupThis is an attempt to fix linked issue.