Skip to content

[Messenger] [AMQP] Throw exception on nack callback #53520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Messenger] [AMQP] Throw exception on nack callback #53520

wants to merge 6 commits into from

Conversation

kvrushifa
Copy link
Contributor

@kvrushifa kvrushifa commented Jan 12, 2024 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53229
License MIT

If the channel is in confirm mode, it is currently not possible to determine if a message has been nack'ed. By throwing an exception within the confirm callback, it is at least possible to react to it.

Return false is not needed to end the wait loop, since the amqp ext checks for exceptions.

@carsonbot carsonbot added this to the 7.1 milestone Jan 12, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Messenger][AMQP-Transport] Throw exception on nack callback [Messenger] [AMQP-Transport] Throw exception on nack callback Jan 12, 2024
@kvrushifa kvrushifa changed the base branch from 7.1 to 6.3 January 12, 2024 01:12
@OskarStark OskarStark changed the title [Messenger] [AMQP-Transport] Throw exception on nack callback [Messenger][AMQP] Throw exception on nack callback Jan 12, 2024
@OskarStark OskarStark changed the title [Messenger][AMQP] Throw exception on nack callback [Messenger][AMQP] Throw exception on nack callback Jan 12, 2024
@kvrushifa kvrushifa changed the base branch from 6.3 to 5.4 January 12, 2024 13:50
@OskarStark OskarStark changed the base branch from 5.4 to 6.3 January 12, 2024 13:54
@OskarStark OskarStark modified the milestones: 7.1, 6.3 Jan 12, 2024
@kvrushifa
Copy link
Contributor Author

⚠️ Please first merge #53525 for SF version 5.4

@carsonbot carsonbot changed the title [Messenger][AMQP] Throw exception on nack callback [Messenger] [AMQP] Throw exception on nack callback Jan 23, 2024
@nicolas-grekas
Copy link
Member

Merged as #53525, this patch will come up to 6.3 as a merge up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

[Messenger] Negative publisher confirm swallowed
4 participants
@kvrushifa @carsonbot @nicolas-grekas @OskarStark