[VarDumper] Fixes Typed property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization
#53521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization
xabbuh
approved these changes
Jan 12, 2024
Not exactly, since 7.0 changed from |
fabpot
approved these changes
Jan 12, 2024
…CliDumper::$colors must not be accessed before initialization`
|
Thank you @crynobone. |
xabbuh
added a commit
that referenced
this pull request
Jan 16, 2024
…r` (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [VarDumper] Fix missing colors initialization in `CliDumper` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Backporting #53521 to 5.4 Commits ------- 6817109 [VarDumper] Fix missing colors initialization in CliDumper
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error:
Other methods in the class start with
$this->colors ??= $this->supportsColors();. I believe this should have the same code.