Skip to content

[Mailer] add Azure and Resend support to the UnsupportedSchemeException #53573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

[Mailer] add Azure and Resend support to the UnsupportedSchemeException #53573

merged 1 commit into from
Jan 18, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 18, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Jan 18, 2024
fabpot
fabpot approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark I'm wondering if we should create a checklist of things we should not forget when adding a new mailer/notifier (and publish it in the docs). WDYT?

@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 96ee1fd into symfony:7.1 Jan 18, 2024
@xabbuh xabbuh deleted the pr-52842-53554 branch January 18, 2024 07:55
@OskarStark
Copy link
Contributor

@OskarStark I'm wondering if we should create a checklist of things we should not forget when adding a new mailer/notifier (and publish it in the docs). WDYT?

Makes sense, if I find some spare time, I will do it.

PS: Another option would be to have dedicated Carsonbot comment with the checklist when a new bridge is added

@OskarStark OskarStark mentioned this pull request Jan 18, 2024
Closed
@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

@OskarStark I'm wondering if we should create a checklist of things we should not forget when adding a new mailer/notifier (and publish it in the docs). WDYT?

Makes sense, if I find some spare time, I will do it.

PS: Another option would be to have dedicated Carsonbot comment with the checklist when a new bridge is added

Carsonbot would be ideal but probably more complex to do. Starting with a manual list will be easier and bring a lot of value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @OskarStark @carsonbot