Skip to content

[TwigBridge] separate child and parent context in NotificationEmail on writes #53663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

[TwigBridge] separate child and parent context in NotificationEmail on writes #53663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Symfony/Bridge/Twig/Mime/NotificationEmail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,23 @@ public function getHtmlTemplate(): ?string
return '@email/'.$this->theme.'/notification/body.html.twig';
}

public function context(array $context)
{
$parentContext = [];

foreach ($context as $key => $value) {
if (\array_key_exists($key, $this->context)) {
$this->context[$key] = $value;
} else {
$parentContext[$key] = $value;
}
}

parent::context($parentContext);

return $this;
}

public function getContext(): array
{
return array_merge($this->context, parent::getContext());
Expand Down
50 changes: 50 additions & 0 deletions src/Symfony/Bridge/Twig/Tests/Mime/NotificationEmailTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,54 @@ public function testPublicMailSubject()
$headers = $email->getPreparedHeaders();
$this->assertSame('Foo', $headers->get('Subject')->getValue());
}

public function testContext()
{
$email = new NotificationEmail();
$email->context(['some' => 'context']);

$this->assertSame([
'importance' => NotificationEmail::IMPORTANCE_LOW,
'content' => '',
'exception' => false,
'action_text' => null,
'action_url' => null,
'markdown' => false,
'raw' => false,
'footer_text' => 'Notification e-mail sent by Symfony',
'some' => 'context',
], $email->getContext());

$context = $email->getContext();
$context['foo'] = 'bar';
$email->context($context);

$this->assertSame([
'importance' => NotificationEmail::IMPORTANCE_LOW,
'content' => '',
'exception' => false,
'action_text' => null,
'action_url' => null,
'markdown' => false,
'raw' => false,
'footer_text' => 'Notification e-mail sent by Symfony',
'some' => 'context',
'foo' => 'bar',
], $email->getContext());

$email->action('Action Text', 'Action URL');

$this->assertSame([
'importance' => NotificationEmail::IMPORTANCE_LOW,
'content' => '',
'exception' => false,
'action_text' => 'Action Text',
'action_url' => 'Action URL',
'markdown' => false,
'raw' => false,
'footer_text' => 'Notification e-mail sent by Symfony',
'some' => 'context',
'foo' => 'bar',
], $email->getContext());
}
}