Skip to content

[Mailer] [Mailgun] Fix sender header encoding #53667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

[Mailer] [Mailgun] Fix sender header encoding #53667

merged 1 commit into from
Jan 29, 2024

Conversation

spajxo
Copy link
Contributor

@spajxo spajxo commented Jan 29, 2024 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #51773 (comment)
License MIT

This adjustment fixes a problem with header encoding in MailgunApiTransport.
The issue occurs only in some cases when using Sender Address with name part with diacritics, because of the difference in encoding of UnstructuredHeader and MailboxHeader.

It changes the method used to add header h:Sender so that MailboxHeader is used.

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@spajxo spajxo marked this pull request as ready for review January 29, 2024 11:18
@carsonbot carsonbot added this to the 6.3 milestone Jan 29, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.0, 7.1.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Mailer][Mailgun] Fix sender header encoding [Mailer] [Mailgun] Fix sender header encoding Jan 29, 2024
@spajxo spajxo changed the base branch from 6.3 to 6.4 January 29, 2024 11:19
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 6.3 January 29, 2024 13:04
@nicolas-grekas
Copy link
Member

Thank you @spajxo.

@nicolas-grekas nicolas-grekas merged commit 893d30e into symfony:6.3 Jan 29, 2024
@spajxo spajxo deleted the fix-mailer-mailgun-sender-header branch January 29, 2024 13:55
This was referenced Jan 30, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@spajxo @carsonbot @nicolas-grekas