[String] Fix plural of word ending by pus #53715
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
2070cd4 to
963318f
Compare
src/Symfony/Component/String/Tests/Inflector/EnglishInflectorTest.php
Outdated
Show resolved
Hide resolved
963318f to
3823582
Compare
|
Thank you @Fan2Shrek. |
| ['supmacoppih', 11, false, false, 'hippocampi'], | ||
|
|
||
| // campuses (campus) | ||
| ['sup', 3, true, true, 'puses'], |
There was a problem hiding this comment.
What about other words ending in pus besides campus and hippocampus ? If we don't have a generic rule, maybe we should actually return the 2 options for the pus ending.
There was a problem hiding this comment.
After some research its seems that only hippocampus is irregular
Words like opus or octopus are plurialized with puses
I'm a non-native english speaker if someone can confirm 👀
Fix the pluralization of words ending by 'pus' like campus.
Previously was campi instead of campuses