Skip to content

[Mailer][Postmark][Webhook] Don't require tag and metadata #53824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

aleho
Copy link
Contributor

@aleho aleho commented Feb 7, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Postmark webhooks will fail if metadata or tag are missing. As both are optional they should not be required in parsing as well.

This was observed in our setup with all webhooks failing because Tag was missing.

Both fields are optional and will be missing from the payload if they
were not set for the outgoing email.
@carsonbot carsonbot added this to the 6.4 milestone Feb 7, 2024
@carsonbot carsonbot changed the title [Mailer][Postmark][Webhook] Don't require tag and metadata [Mailer][Webhook] [Postmark] Don't require tag and metadata Feb 7, 2024
@aleho aleho changed the title [Mailer][Webhook] [Postmark] Don't require tag and metadata [Mailer][Postmark][Webhook] Don't require tag and metadata Feb 7, 2024
@nicolas-grekas
Copy link
Member

Thank you @aleho.

@nicolas-grekas nicolas-grekas merged commit 8f98550 into symfony:6.4 Feb 8, 2024
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants