[Mailer][Postmark][Webhook] Accept different date formats #53829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postmark webhooks sometimes use "plain" ISO 6801 format, sometimes including 7 digits microseconds. As the PHP parameter only allows for 6 digits neither would parse without fallbacks. Fixes symfony#53788
aa9e308 to
8af3d02
Compare
|
@nicolas-grekas I replaced all the custom formats in the tests with PHP's "official" ISO 8601 format. I guess it's supposed to be compatible with the standard and if not, Postmark is sending broken webhooks anyway. Is that OK? |
|
Thank you @aleho. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postmark webhooks sometimes use "plain" ISO 6801 format, sometimes including 7 digits microseconds.
We're currently seeing
2024-02-07T09:41:16.7048881Zfor example.As the PHP parameter only allows for 6 digits neither would parse without fallbacks.