Skip to content

[VarDumper] Fixed broken CI #53854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[VarDumper] Fixed broken CI #53854

wants to merge 1 commit into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Feb 7, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Make sure we dont compare a "color output" with a plain one.

I think this was introduced in #53794

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@Nyholm Nyholm changed the base branch from 7.1 to 5.4 February 7, 2024 23:22
@Nyholm Nyholm modified the milestones: 7.1, 5.4 Feb 7, 2024
@Nyholm
Copy link
Member Author

Nyholm commented Feb 8, 2024

Maybe #53856 is a better fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants