[Mailer][Postmark][Webhook] Fix webhook testing in dockerized setups #53869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "127.0.0.1" to webhooks doesn't always cut it. Testing in e.g. dockerized setups the IP address will most certainly not be 127.0.0.1 when testing requests originate from the host.
22f0d4d to
5a2bcdd
Compare
nicolas-grekas
approved these changes
Feb 9, 2024
|
Thank you @aleho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "127.0.0.1" to webhooks doesn't always cut it. Testing in e.g. dockerized setups the IP address will most certainly not be 127.0.0.1 when testing requests originate from the host.
I wasn't sure whether this is a bug or a feature. For us it's a bug (we cannot test webhooks here, if "test" means testing in our development environment). On the other hand, it could also be a feature (and "127.0.0.1" removed completely), if by "testing" only the Symfony tests were meant.
What do you think? Bug? Feature?