Skip to content

[DependencyInjection] fix unable to make lazy service from readonly class #53876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

kor3k
Copy link
Contributor

@kor3k kor3k commented Feb 8, 2024

[DependencyInjection] unable to make lazy service from readonly class #53843

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53843
License MIT

@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] unable to make lazy service from readonly class [DependencyInjection] fix unable to make lazy service from readonly class Feb 9, 2024
@nicolas-grekas
Copy link
Member

Thank you @kor3k.

@nicolas-grekas nicolas-grekas merged commit 84c231e into symfony:6.4 Feb 9, 2024
nicolas-grekas added a commit that referenced this pull request Feb 9, 2024
This PR was merged into the 6.4 branch.

Discussion
----------

[DependencyInjection] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | see the test failures after #53876
| License       | MIT

Commits
-------

d6352f8 fix tests
This was referenced Feb 27, 2024
derrabus added a commit that referenced this pull request May 3, 2024
…n check (xabbuh)

This PR was merged into the 7.0 branch.

Discussion
----------

[DependencyInjection] remove no longer needed PHP version check

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

possible after merging up #53876

Commits
-------

59ec34b remove no longer needed PHP version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants