Skip to content

[VarExporter] Uniform unitialized property error message under ghost and non-ghost objects #53890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

priyadi
Copy link
Contributor

@priyadi priyadi commented Feb 10, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Accessing an uninitialized property will previously give us a different error message on a lazy ghost and the real object. This PR changes so that doing it on a lazy ghost gives us the same error message as that with the real object.

@priyadi
Copy link
Contributor Author

priyadi commented Feb 10, 2024

fabbot's php-cs-fixer report is ignored. It breaks the result by fixing it.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

@nicolas-grekas nicolas-grekas force-pushed the uniform-error-message-ghost-and-nonghost branch from 78f73cb to fa3a112 Compare February 12, 2024 10:26
@nicolas-grekas
Copy link
Member

Thank you @priyadi.

@nicolas-grekas nicolas-grekas merged commit 7cbf1fc into symfony:6.4 Feb 12, 2024
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants