Skip to content

[Serializer] Fix unknown types normalization type when know type #53959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[Serializer] Fix unknown types normalization type when know type #53959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,16 @@ protected function instantiateObject(array &$data, string $class, array &$contex
continue;
}

$constructorParameterType = 'unknown';
$reflectionType = $constructorParameter->getType();
if ($reflectionType instanceof \ReflectionNamedType) {
$constructorParameterType = $reflectionType->getName();
}

$exception = NotNormalizableValueException::createForUnexpectedDataType(
sprintf('Failed to create object because the class misses the "%s" property.', $constructorParameter->name),
$data,
['unknown'],
[$constructorParameterType],
$context['deserialization_path'],
true
);
Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Component/Serializer/Tests/SerializerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ public function testCollectDenormalizationErrorsWithConstructor(?ClassMetadataFa
[
'currentType' => 'array',
'expectedTypes' => [
'unknown',
'string',
],
'path' => 'string',
'useMessageForUser' => true,
Expand All @@ -1317,7 +1317,7 @@ public function testCollectDenormalizationErrorsWithConstructor(?ClassMetadataFa
[
'currentType' => 'array',
'expectedTypes' => [
'unknown',
'int',
],
'path' => 'int',
'useMessageForUser' => true,
Expand Down Expand Up @@ -1548,7 +1548,7 @@ public function testPartialDenormalizationWithMissingConstructorTypes()
[
'currentType' => 'array',
'expectedTypes' => [
'unknown',
'string',
],
'path' => 'two',
'useMessageForUser' => true,
Expand Down