[Process] Normalize exceptions #5398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passes, it's a travis issue, see http://travis-ci.org/#!/symfony/symfony/builds/2287439 |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2012
Commits ------- c5e7793 [Process] Normalize exceptions Discussion ---------- [Process] Normalize exceptions Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT There were some exceptions in the Process scope but they were not implemented everywhere in the component. This PR ensure that all exceptions thrown inside Process implements `Process\Exception\ExceptionInterface`. --------------------------------------------------------------------------- by romainneutron at 2012-08-30T20:05:41Z Tests passes, it's a travis issue, see http://travis-ci.org/#!/symfony/symfony/builds/2287439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
There were some exceptions in the Process scope but they were not implemented everywhere in the component.
This PR ensure that all exceptions thrown inside Process implements
Process\Exception\ExceptionInterface.