Skip to content

[HttpKernel] Fix a minor design issue in the Welcome Page #54005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

This was spotted by @nicolas-grekas. In the Welcome Page, the toolbar needs a position CSS property because otherwise, the z-index property is ignored and the following happens:

toolbar-position.mp4

@carsonbot carsonbot added this to the 7.0 milestone Feb 20, 2024
@carsonbot carsonbot changed the title Fix a minor design issue in the Welcome Page [HttpKernel] Fix a minor design issue in the Welcome Page Feb 20, 2024
@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit 635a9f1 into symfony:7.0 Feb 20, 2024
@javiereguiluz javiereguiluz deleted the welcome_page_fix branch February 23, 2024 16:59
@fabpot fabpot mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants