[Config] ConfigBuilderGenerator: define template types #54008
Conversation
2e524b4 to
eca96b0
Compare
src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php
Outdated
Show resolved
Hide resolved
This helps phpstan to properly identify the return types, in our case for the `$framework->messenger()->transport('async')->dsn(env('MESSENGER_TRANSPORT_DSN'));`
Where '->dns()` failed with the following Phpstan error:
`Call to an undefined method Symfony\Config\Framework\Messenger\TransportConfig|Symfony\Config\Framework\MessengerConfig::dsn()`
true, all the test cases were only handling |
|
Another issue we identified is the messenger routing configuration, which confuses PhpStan. But could not find a way to solve it, notes:
|
@thePanz for some reason PHPStan have two problems here that should be solved on PHPStan side (I think), conditional return on template does not work properly, and native return with I have also reported bug for the dead code / bad native typing to Edit: this would also work for PHPStan even with conditional return based on generics https://phpstan.org/r/9ecae399-0ee4-4deb-9dc5-a1f3db4017b0 |
This helps phpstan to properly identify the return types, in our case for the
$framework->messenger()->transport('async')->dsn(env('MESSENGER_TRANSPORT_DSN'));Where
->dns()failed with the following Phpstan error:Call to an undefined method Symfony\Config\Framework\Messenger\TransportConfig|Symfony\Config\Framework\MessengerConfig::dsn()