[VarExporter] Bugfix/workaround jit issue #54054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Did you report the issue to php-src? It should be fixed there ideally, and VarExporter could be showcased as the reproducer for them. |
|
I'm now seeing php/php-src#13508 so I have my answer :) |
|
i did :) |
see symfony#54053 for more context
96008d6 to
b9a9d35
Compare
|
Thank you @verfriemelt-dot-org |
|
@nicolas-grekas any ETA on next 6.4 minor release with this fix? |
|
We do releases at the end of each months (and we're at the end of one, so shouldn't be long.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to fix the erratically behavior with this patch, but i have no idea how one would test this.
It seems tracing jit has some issues with the ternary operator.
Let me know what you think, i have no idea how to work with that properly :)