[Validator] Simplify NoSuspiciousCharactersValidator
#54062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 26, 2024
OskarStark
approved these changes
Feb 27, 2024
xabbuh
reviewed
Feb 27, 2024
src/Symfony/Component/Validator/Constraints/NoSuspiciousCharactersValidator.php
Outdated
Show resolved
Hide resolved
|
I forgot the case where many checks fail at once; adding a test. This will also solve #54062 (comment). |
816e1fc to
c24e3e7
Compare
|
Thank you @MatTheCat. |
stof
reviewed
Feb 27, 2024
| ->assertRaised(); | ||
| ; | ||
|
|
||
| while ($message = next($errors)) { |
There was a problem hiding this comment.
foreach ($errors as $code => $message) would be a lot more readable IMO (you will need a special handling of the first item s next ones to create $violations)
| [NoSuspiciousCharacters::HIDDEN_OVERLAY_ERROR => 'Using hidden overlay characters is not allowed.'], | ||
| ]; | ||
|
|
||
| yield 'Fails both HIDDEN_OVERLAY and RESTRICTION_LEVEL checks' => [ |
There was a problem hiding this comment.
shouldn't this test be added in older branches as well (and so all the test refactoring) ?
xabbuh
added a commit
that referenced
this pull request
Nov 14, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Validator] fix compatibility with PHP < 8.2.4 | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The fix for php/php-src#10647 (on which #54062) relies on was first released with PHP 8.2.4. Commits ------- 2d713ea fix compatibility with PHP < 8.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php/php-src#10647 has been fixed in PHP 8.1.17. Now that Symfony requires PHP ≥ 8.2, we can avoid calling
Spoofchecker::isSuspiciousfor every check by leveraging its$errorCodeparameter.