[Console] Better error handling when misuse of ArgvInput with arrays #54147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that we usually don't merge DX improvements as bugfixes. Thus, you should target 7.1 for this change. |
derrabus
reviewed
Mar 4, 2024
Comment on lines
+50
to
+52
| if (array_filter($argv, 'is_array')) { | ||
| throw new RuntimeException('Argument values expected to be all scalars, got array.'); | ||
| } |
There was a problem hiding this comment.
Catching arrays feels a bit arbitrary. What about objects? Resources?
Should we instead check for values that cannot be cast to string?
There was a problem hiding this comment.
Something like this (I'm not sure for the Stringable):
Suggested change
| if (array_filter($argv, 'is_array')) { | |
| throw new RuntimeException('Argument values expected to be all scalars, got array.'); | |
| } | |
| foreach($argv as $arg) { | |
| if (!is_scalar($arg) && !$arg instanceof \Stringable) { | |
| throw new RuntimeException(sprintf('Argument values expected to be all scalars, got "%s".', get_debug_type($arg))); | |
| } | |
| } |
86b7728 to
0d7641e
Compare
|
New PR #54576 targeting 7.1 |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2024
… with arrays (symfonyaml) This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Console] Better error handling when misuse of `ArgvInput` with arrays | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #53836 | License | MIT ### Issue When we don't use `ArgvInput` correclty, and use array in $argv values, it returns different PHP fatal errors. See all details and how to reproduce it in the issue #53836 ### Solution In this PR - Add some DX with an exception explaining the problem, to avoid PHP fatal errors - Add tests** _____ Note : Old PR #54147 was targeting 5.4, see [this comment](#54147 (comment)) for more details Commits ------- 6f64cf4 [Console] Better error handling when misuse of `ArgvInput` with arrays
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Jun 3, 2024
… with arrays (symfonyaml) This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Console] Better error handling when misuse of `ArgvInput` with arrays | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #53836 | License | MIT ### Issue When we don't use `ArgvInput` correclty, and use array in $argv values, it returns different PHP fatal errors. See all details and how to reproduce it in the issue symfony/symfony#53836 ### Solution In this PR - Add some DX with an exception explaining the problem, to avoid PHP fatal errors - Add tests** _____ Note : Old PR #54147 was targeting 5.4, see [this comment](symfony/symfony#54147 (comment)) for more details Commits ------- 6f64cf4f80 [Console] Better error handling when misuse of `ArgvInput` with arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When we don't use
ArgvInputcorreclty, and use array in $argv values, it returns different PHP fatal errors.See all details and how to reproduce it in the issue #53836
Solution
In this PR
Note : Old PR #53838