Skip to content

[Notifier] LOX24 SMS bridge #54356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2024
Merged

[Notifier] LOX24 SMS bridge #54356

merged 1 commit into from
Apr 14, 2024

Conversation

alebedev80
Copy link
Contributor

@alebedev80 alebedev80 commented Mar 20, 2024 •
edited by xabbuh
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#19692
Recipe PR symfony/recipes#1300

Add LOX24 SMS Gateway bridge to Symfony Notifier.
A Germany based SMS Gateway.

@alebedev80 alebedev80 requested a review from OskarStark as a code owner March 20, 2024 17:43
@carsonbot carsonbot added this to the 7.1 milestone Mar 20, 2024
@alebedev80 alebedev80 changed the base branch from 7.1 to 6.4 March 20, 2024 17:56
@xabbuh xabbuh changed the base branch from 6.4 to 7.1 March 20, 2024 20:29
@symfony symfony deleted a comment from carsonbot Mar 21, 2024
OskarStark
OskarStark requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your class to the framework config and to the Notifier: UnsupportedSchemeException/UnsupportedSchemeExceptionTest classes, thanks

@alebedev80
Copy link
Contributor Author

alebedev80 commented Mar 21, 2024 •
edited
Loading

@OskarStark what's data should be by indexes 0 and 1? method \Symfony\Component\Notifier\Test\TransportFactoryTestCase::createProvider()

    /**
     * @return iterable<array{0: string, 1: string, 2: TransportInterface}>
     */
    abstract public static function createProvider(): iterable;

@OskarStark
Copy link
Contributor

OskarStark commented Mar 21, 2024 •
edited
Loading

Please have a look at other bridges tests

@carsonbot carsonbot changed the title LOX24 SMS Gateway Notifier [Notifier] LOX24 SMS Gateway Notifier Mar 21, 2024
@OskarStark OskarStark changed the title [Notifier] LOX24 SMS Gateway Notifier [Notifier] LOX24 SMS bridge Mar 21, 2024
welcoMattic
welcoMattic reviewed Mar 21, 2024
View reviewed changes
@alebedev80
Copy link
Contributor Author

@OskarStark i think i fixed everything which you mentioned. I'm sorry if missed something...
Please review code again.

@alebedev80 alebedev80 requested a review from OskarStark March 21, 2024 09:19
@alebedev80 alebedev80 requested a review from welcoMattic March 21, 2024 09:38
stof
stof reviewed Mar 21, 2024
View reviewed changes
OskarStark
OskarStark reviewed Apr 13, 2024
View reviewed changes
OskarStark
OskarStark reviewed Apr 13, 2024
View reviewed changes
@alebedev80
Copy link
Contributor Author

@OskarStark please check again

@alebedev80 alebedev80 requested a review from OskarStark April 13, 2024 12:22
OskarStark
OskarStark reviewed Apr 13, 2024
View reviewed changes
@alebedev80
Copy link
Contributor Author

@OskarStark fixed.
Please check again

@alebedev80 alebedev80 requested a review from OskarStark April 13, 2024 16:44
smnandre
smnandre reviewed Apr 13, 2024
View reviewed changes
smnandre
smnandre reviewed Apr 13, 2024
View reviewed changes
smnandre
smnandre reviewed Apr 13, 2024
View reviewed changes
@alebedev80 alebedev80 requested a review from smnandre April 13, 2024 17:39
OskarStark
OskarStark approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side

@OskarStark OskarStark requested review from fabpot and removed request for smnandre April 13, 2024 18:49
@OskarStark
Copy link
Contributor

Tests are failing

@alebedev80 alebedev80 requested a review from smnandre April 13, 2024 19:09
@alebedev80
Copy link
Contributor Author

Tests are failing

Fixed

@fabpot
Copy link
Member

fabpot commented Apr 14, 2024

Thank you @alebedev80.

@fabpot fabpot merged commit cfd9ad0 into symfony:7.1 Apr 14, 2024
@alebedev80
Copy link
Contributor Author

Thank you all!

@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

@kbond kbond Awaiting requested review from kbond

@chalasr chalasr Awaiting requested review from chalasr

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

@stof stof Awaiting requested review from stof

@smnandre smnandre Awaiting requested review from smnandre

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
7 participants
@alebedev80 @OskarStark @fabpot @stof @welcoMattic @smnandre @carsonbot