Skip to content

[WebProfilerBundle] Update the search links in the profiler layout #54423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

While working on #54421, I noticed that the page jump is mostly caused by the "profile search form" that we embed in the page via Ajax. This is how it looks expanded:

image

However, thew workflow is as follows:

  1. Click on Search link
  2. The embedded search form expands
  3. Input the search criteria
  4. Click on Search button
  5. You are redirected to the Search page to see the results

In this PR, I propose to NOT embed the search form in any pages and change the workflow as follows:

  1. Click on Search link
  2. You are redirected to the Search page to see the results
  3. Input the search criteria (in the already expanded search form)
  4. Click on Search button to see the results

This fixes some of the perceived performance slowdown and looks like a better workflow to me.


Also, the current sidebar shows these shortcut links:

image

  • "Last 10" shows the 10 most recent profiles
  • "Latest" shows the most recent profile available
  • "Search" expands the search form

This PR changes it to only show 2 shortcuts:

  • "Search profiles" shows the last 10 profiles and also the search form expanded
  • "Latest" shows the most recent profile aaailable

It looks like this:

search-links

@javiereguiluz javiereguiluz added this to the 7.1 milestone Mar 27, 2024
@javiereguiluz javiereguiluz added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 2, 2024
@fabpot fabpot force-pushed the profiler_search branch from 765e7f7 to 7baa29e Compare April 5, 2024 06:41
@fabpot
Copy link
Member

fabpot commented Apr 5, 2024

Thank you @javiereguiluz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed WebProfilerBundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants