[Routing] UrlGenerator: fixed missing query param and some ignored requirements #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot ping |
|
IIUC, #5437 is a regression in 2.1 and should be done in 2.1, no? |
|
It's not in 2.1 anymore as you reverted the PR. #5437 is not valid currently and can be closed. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2012
This PR was merged into the master branch. Commits ------- e22823b [Routing] context params should have higher priority than defaults 16c1b01 [Routing] fixed 4 bugs in the UrlGenerator Discussion ---------- [Routing] UrlGenerator: fixed missing query param and some ignored requirements reopened version of #5181 (cherry-picked) On top of that I fixed #5437 in my code and added test case. --------------------------------------------------------------------------- by Tobion at 2012-10-03T18:41:45Z @fabpot ping --------------------------------------------------------------------------- by fabpot at 2012-10-03T18:43:43Z IIUC, #5437 is a regression in 2.1 and should be done in 2.1, no? --------------------------------------------------------------------------- by Tobion at 2012-10-03T18:46:42Z It's not in 2.1 anymore as you reverted the PR. #5437 is not valid currently and can be closed. So this can either be merged in master or 2.1 whatever you prefer.
fabpot
added a commit
that referenced
this pull request
Oct 3, 2012
This PR was merged into the master branch. Commits ------- faee47c added note in changelog about disabling requirements check 5fbed36 extended phpdoc of ConfigurableRequirementsInterface 1964d43 [Routing] added test for disabled requirements check 98fb915 [Routing] allow disabling the requirements check on URL generation Discussion ---------- [Routing] allow disabling the requirements check on URL generation Reopened version of #5187 Requires #5445 first --------------------------------------------------------------------------- by fabpot at 2012-10-03T19:03:25Z Can you rebase on master and add a note in the CHANGELOG? Also, I think the doc should be updated accordingly. Thanks. --------------------------------------------------------------------------- by Tobion at 2012-10-03T19:04:07Z @fabpot ping. The config for this feature is already present in master in symfony-standard. See [config_prod.yml](https://github.com/symfony/symfony-standard/blob/master/app/config/config_prod.yml) --------------------------------------------------------------------------- by Tobion at 2012-10-03T19:06:53Z Hehe, I already rebased while you wrote that. You mean I should add a tip to the routing component documentation? Sure, I have alread planned to adjust the symfony doc for the recent routing PRs. --------------------------------------------------------------------------- by fabpot at 2012-10-03T19:12:36Z Just adding a note about the new possibility in the CHANGELOG. --------------------------------------------------------------------------- by Tobion at 2012-10-03T19:53:19Z @fabpot done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopened version of #5181 (cherry-picked)
On top of that I fixed #5437 in my code and added test case.