Skip to content

[VarExporter] remove Ignore attribute from setLazyObjectAsInitialized() method #54480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[VarExporter] remove Ignore attribute from setLazyObjectAsInitialized() method #54480

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 3, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54477
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Apr 3, 2024
@nicolas-grekas
Copy link
Member

Wait, this breaks LazyGhostTraitTest::testNormalization. :'(

@xabbuh
Copy link
Member Author

xabbuh commented Apr 4, 2024

The only solution I see for now is to disallow normalizing classes using the LazyGhostTrait again. :(

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 4, 2024 •
edited
Loading

Can't we make Serializer aware of the trait so that it skips those methods?
Alternatively, we might just remove this exception Ignore can only be added on methods beginning with "get", "is", "has" or "set".
It's useless to me. Ignore means ignore, not yell.

@nicolas-grekas
Copy link
Member

Replaced by #54485, thanks for chiming in!

@xabbuh xabbuh deleted the issue-54477 branch April 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Bug Status: Needs Work VarExporter
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @jderusse @carsonbot