Skip to content

Proofread UPGRADE guide #54533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Proofread UPGRADE guide #54533

merged 1 commit into from
Apr 17, 2024

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Apr 9, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Feature-freeze is upon us, so here is a new proofread of the UPGRADE guide. It seems like we didn't introduce many deprecations this time. I've scanned all CHANGELOG files to find missing items.

@wouterj wouterj requested review from xabbuh and yceruto as code owners April 9, 2024 10:16
@carsonbot carsonbot added this to the 7.1 milestone Apr 9, 2024
Mailer
------

* Postmark's "406 - Inactive recipient" API error code now results in a `PostmarkDeliveryEvent` instead of throwing a `HttpTransportException`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we should classify this as a BC BREAK or not. Technically, if you now handled this in an exception handler your code will be broken. On the other hand, anything that has proper handling now and was an error before is often called a feature.

UPGRADE-7.1.md Outdated
@@ -1,6 +1,38 @@
UPGRADE FROM 7.0 to 7.1
=======================

Symfony 7.1 is a minor release. According to the Symfony release process, there should be no significant
backwards compatibility breaks. Minor backwards compatibility breaks are prefixed in this document with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backwards compatibility breaks. Minor backwards compatibility breaks are prefixed in this document with
backward compatibility breaks. Minor backward compatibility breaks are prefixed in this document with

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With suggestions applied

@OskarStark OskarStark added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 12, 2024
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouter, thanks for taking care of this.

@fabpot
Copy link
Member

fabpot commented Apr 17, 2024

Thank you @wouterj.

@fabpot fabpot merged commit b0724ba into symfony:7.1 Apr 17, 2024
1 check was pending
@wouterj wouterj deleted the upgrade-71 branch April 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.