Skip to content

[HttpKernel] Force non lazy controller services #54547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Apr 10, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54542
License MIT

Controllers registered as lazy services created a bug where IsGranted attribute were ignored.

Following @nicolas-grekas suggestion, this PR enfore that controllers are not registered as lazy.

@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 5.4 April 11, 2024 06:29
@nicolas-grekas nicolas-grekas force-pushed the fix/force-controller-non-lazy branch from 38a7da6 to 38d71d6 Compare April 11, 2024 06:29
@nicolas-grekas
Copy link
Member

Thank you @smnandre.

@nicolas-grekas nicolas-grekas merged commit 9226902 into symfony:5.4 Apr 11, 2024
8 of 12 checks passed
This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants