[Process] add signal method. #5457
Conversation
|
please add test. |
| */ | ||
| public function signal($signal) | ||
| { | ||
| return proc_terminate($this->process, $signal); |
There was a problem hiding this comment.
Wrong indent.
Also what with: https://bugs.php.net/bug.php?id=39992 ?
There was a problem hiding this comment.
I can't speak for not terminating child, but as I commented in issue the signal seems to be sent through to child.
|
Short of doing something like http://php.net/manual/en/function.pcntl-signal.php and listening for a signal in a PHP process I am not sure how to test this. Possibly depend on some system process that pics up signals, but that doesn't necessarily seem like a good idea. |
|
Already proposed in #5391 |
|
Looks like they took my advice and used proc_terminate() so another package was not needed. Thanks for catching duplicate, but at least it was not a waste. :) |
|
yup thanks @boombatower :) |
Pull request for issue #5454.
Perhaps a signal($signal) method instead of kill() since stop is already taking that role and looks like other issue already talking about sending SIGTERM vs SIGKILL and what not.
It might be a good idea to limit the signals you can send so you don't terminate using this function. Also probably a good idea to have a list of POSIX signals as constants.
Thoughts?