[Intl] Remove resources data from classmap generation #54625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Apr 16, 2024
fabpot
approved these changes
Apr 16, 2024
|
Thank you @shyim. |
|
Please do the same in the 7.1 branch for the Emoji component. |
fabpot
added a commit
that referenced
this pull request
Apr 17, 2024
…shyim) This PR was merged into the 7.1 branch. Discussion ---------- [Emoji] Remove resources data from classmap generation | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Same as #54625 but for Emoji, FYI: `@stof` Commits ------- fddce25 [Emoji] Remove resources data from classmap generation
This was referenced Apr 29, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed why my
composer installtakes 5 seconds to complete, so I debugged and the most time-consuming was optimized autoloader generation. Looking more deep into, I figured out that Composer looks into any of the "Data PHP" files of Intl. Removed it and it make it much faster for me. It has no negativ effect to Intl component removing them from classmap, as they don't contain something autoloadable.composer dumpautoload -oon my project with 137 packagesBefore: 4.662s
After: 1.833s