[String] Fix #54611 pluralization of -on ending words + singularization of -a ending foreign words #54634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The common typo issue reported by fabbot.io is not a typo here. |
|
The |
nicolas-grekas
approved these changes
Apr 23, 2024
|
(you need to bump the version of the string component in the composer.json file to fix the deps=low tests) |
|
@nicolas-grekas you lost me on this because I don't know to which version should I bump the string component in the composer file of the inflector component as the PR fixes the string component. I obviously can't use 5.4.x-dev ... |
|
The next version is 5.4.39 |
xabbuh
requested changes
Apr 24, 2024
| @@ -26,7 +26,7 @@ | |||
| "php": ">=7.2.5", | |||
| "symfony/deprecation-contracts": "^2.1|^3", | |||
| "symfony/polyfill-php80": "^1.16", | |||
| "symfony/string": "^5.3.10|^6.0" | |||
| "symfony/string": "^5.4.39|^6.0" | |||
There was a problem hiding this comment.
Suggested change
| "symfony/string": "^5.4.39|^6.0" | |
| "symfony/string": "^5.4.39|^6.4.7" |
fabpot
approved these changes
Jun 9, 2024
…arization of -a ending foreign words
|
Thank you @DesLynx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the pluralization of -on ending words as -ons (with exception for "criterion" and "phenomenon")
fix singularization of -a ending foreign words (see https://english-zone.com/spelling/plurals.html)
note: I left "data" uninflected because it seems to me that changing it to the datum/data inflection could cause side effects as "data" is a widely used word (especially in the coding world).