Skip to content

[Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it was a BC Break #54635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

[Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it was a BC Break #54635

merged 1 commit into from
Apr 17, 2024

Conversation

NeilPeyssard
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54488
License MIT

Revert changes from this PR #54148 (BC Break).

@NeilPeyssard NeilPeyssard requested a review from dunglas as a code owner April 17, 2024 12:47
@carsonbot carsonbot added this to the 5.4 milestone Apr 17, 2024
chalasr
chalasr approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR welcome to make this change on 7.x (smoothly if possible i.e. with deprecation).

@chalasr chalasr mentioned this pull request Apr 17, 2024
Closed
@nicolas-grekas nicolas-grekas changed the title [Serializer] Revert #54488 to fix BC Break [Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it's a BC Break Apr 17, 2024
@nicolas-grekas nicolas-grekas changed the title [Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it's a BC Break [Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it was BC Break Apr 17, 2024
@nicolas-grekas nicolas-grekas changed the title [Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it was BC Break [Serializer] Revert "Fix object normalizer when properties has the same name as their accessor" - it was a BC Break Apr 17, 2024
@nicolas-grekas
Copy link
Member

Thank you @NeilPeyssard.

@nicolas-grekas nicolas-grekas merged commit 7bb819e into symfony:5.4 Apr 17, 2024
8 of 12 checks passed
@nvdbeek
Copy link

nvdbeek commented Apr 23, 2024

@nicolas-grekas when are you creating a new tag for this 'misbehavior'? We cannot update our 6.4.x cause of this.

@nicolas-grekas
Copy link
Member

We tag at the end of the month, so one week max.

This was referenced Apr 29, 2024
Merged
Merged
Merged
@xabbuh xabbuh mentioned this pull request May 15, 2024
Closed
@renovate renovate bot mentioned this pull request Sep 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@NeilPeyssard @nicolas-grekas @nvdbeek @chalasr @carsonbot