Auto-close PRs on subtree-splits #54653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0c1177 to
c3ff44e
Compare
stof
reviewed
Apr 18, 2024
stof
approved these changes
Apr 18, 2024
|
Awesome, thank you! |
kbond
added a commit
to symfony/ux
that referenced
this pull request
Apr 18, 2024
This PR was merged into the 2.x branch. Discussion ---------- Auto-close PRs on subtree-splits | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Same as symfony/symfony#54653 Commits ------- 63ee860 Auto-close PRs on subtree-splits
This was referenced Apr 18, 2024
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Apr 19, 2024
This PR was merged into the 1.x branch. Discussion ---------- Auto-close PRs on subtree-splits Same as symfony/symfony#54653 Commits ------- 78bbd28 Auto-close PRs on subtree-splits
nicolas-grekas
added a commit
to twigphp/Twig
that referenced
this pull request
Apr 19, 2024
This PR was merged into the 3.x branch. Discussion ---------- Auto-close PRs on subtree-splits Same as symfony/symfony#54653 Commits ------- b212f1b Auto-close PRs on subtree-splits
fabpot
added a commit
that referenced
this pull request
Apr 26, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [Security] Remove workflow from empty folder | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT The workflows were add in #54653, but the Guard component was removed in 6.0, so there's just an empty folder now on higher versions. Commits ------- 2aaec67 [Security] Remove workflow from empty folder
fabpot
added a commit
that referenced
this pull request
May 31, 2024
fabpot
added a commit
that referenced
this pull request
May 31, 2024
* 5.4: Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
fabpot
added a commit
that referenced
this pull request
May 31, 2024
* 6.4: Remove subtree split checks Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
fabpot
added a commit
that referenced
this pull request
May 31, 2024
* 7.0: Remove subtree split checks Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
fabpot
added a commit
that referenced
this pull request
May 31, 2024
* 7.1: Remove subtree split checks Remove subtree split checks Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)" [SecurityBundle] Fix `container.build_hash` parameter binding [Serializer] Fix denormalizing a collection of union types [DoctrineBridge] Fix `UniqueEntityValidator` with proxy object
nicolas-grekas
added a commit
that referenced
this pull request
Sep 25, 2024
…itories (GromNaN) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Add PR template and auto-close PR on subtree split repositories | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #57267 | License | MIT Extract the Pull Request Template from #54653. ~The GitHub action did not work as said by `@nicolas`-grekas #57267 (comment) Replaced by https://github.com/superbrothers/close-pull-request. Commits ------- d90fa7a Add PR template and auto-close PR on subtree split repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, people submit PRs on subtree splits.
We used to auto-close them using a bot. But maintaining a bot is boring.
Later on GitHub introduced org-wide workflows. Then removed them.
Here, I propose we add a
.githubfolder to all our packages, with an action to auto-close PRs.