[HttpClient] Implemented LoggerAwareInterface in HttpClientInterface decorators #54668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Psr\Log\LoggerAwareInterface
inSymfony\Component\HttpClient\UriTemplateHttpClient
.I was on a journey to enhance our logs on a project that highly depend on
HttpClient
.I started to separate logs per feature, and I wanted to include
HttpClient
logs to the logger of the currently running the feature.I figured out that most implementations of
HttpClientInterface
are implementingLoggerAwareInterface
, so I decided to just call$client->setLogger(...)
on my side.And nothing changed.
Nothing changed because my logger is decorated by the
UriTemplateHttpClient
that is not implementingLoggerAwareInterface
.Althought
UriTemplateHttpClient
has no need of a logger, as a decorator it should be able to act like it, so the underlying client can be reached.This is what is done for instance in
Symfony\Component\HttpClient\TraceableHttpClient
.