Skip to content

[TypeInfo] Proxies methods to non-nullable and fail gracefully #54679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

[TypeInfo] Proxies methods to non-nullable and fail gracefully #54679

merged 1 commit into from
May 31, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Apr 20, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT
  • Proxies methods of "nullable union types" (ie: string|null) on non-nullable related type.
  • Gracefully fail with a LogicException on invalid method call. This allows for example to call getClassName on every Type within a try/catch block, without having to retrieve the very precise type holding the class name.

@carsonbot carsonbot added this to the 7.1 milestone Apr 20, 2024
@mtarld mtarld force-pushed the fix/proxies-methods branch from fffe41f to 0ab53b2 Compare April 20, 2024 14:34
Korbeil
Korbeil approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 30, 2024
@nicolas-grekas nicolas-grekas modified the milestones: 7.1, 7.2 May 2, 2024
@nicolas-grekas nicolas-grekas removed the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label May 2, 2024
@xabbuh xabbuh added the Feature label May 15, 2024
@fabpot fabpot force-pushed the fix/proxies-methods branch from 0ab53b2 to 0053750 Compare May 31, 2024 06:56
@fabpot
Copy link
Member

fabpot commented May 31, 2024

Thank you @mtarld.

@fabpot fabpot merged commit f73a301 into symfony:7.2 May 31, 2024
4 of 10 checks passed
@fabpot fabpot mentioned this pull request May 31, 2024
Closed
@mtarld mtarld deleted the fix/proxies-methods branch May 31, 2024 07:05
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Korbeil Korbeil Korbeil approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@mtarld @fabpot @Korbeil @chalasr @nicolas-grekas @xabbuh @carsonbot