Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.4, or 7.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

There is a minor CS remaining spotted by fabbot https://fabbot.io/report/symfony/symfony/54726/6b8a8b268f32cd4037a04d217aa8bb551774cf51

There is a minor CS remaining spotted by fabbot https://fabbot.io/report/symfony/symfony/54726/6b8a8b268f32cd4037a04d217aa8bb551774cf51

https://fabbot.io/patch/symfony/symfony/54726/6b8a8b268f32cd4037a04d217aa8bb551774cf51/exception_messages.diff
This change request is weird isn't it ? It concern to add '.' before quote in the string

I'm not entirely convinced, we need this feature, tbh. My biggest concern is that we change a well established interface and add an unnecessary method to it.

If your main motivation is saving a few keystrokes of boilerplate in controllers, let's add that method to the AbstractController class or some trait instead?

I'm not entirely convinced, we need this feature, tbh. My biggest concern is that we change a well established interface and add an unnecessary method to it.

If your main motivation is saving a few keystrokes of boilerplate in controllers, let's add that method to the AbstractController class or some trait instead?

This is an interesting observation, I can make a new PR to write this in AbstractController:

$form = $this->createForm(FormType::class);
if ($this->isSubmittedFormValid($form, $request)) {
}

I don't think this will be useful except to not forget the handleRequest method

This is an interesting observation, I can make a new PR to write this in AbstractController:

$form = $this->createForm(FormType::class);
if ($this->isSubmittedFormValid($form, $request)) {
}

If we want to have such a utility function in the core at all, I think AbstractController is the place.

It rewrite the method in AbstractController: #54743