Skip to content

[Notifier] [Bluesky] Allow to attach image #54756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2024
Merged

[Notifier] [Bluesky] Allow to attach image #54756

merged 1 commit into from
May 21, 2024

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Apr 28, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

Allow to embed an image to a bluesky post.

@carsonbot

This comment was marked as outdated.

Sign in to view
@jdecool jdecool marked this pull request as ready for review April 28, 2024 08:58
@jdecool jdecool requested a review from OskarStark as a code owner April 28, 2024 08:58
@carsonbot carsonbot added this to the 7.1 milestone Apr 28, 2024
@OskarStark OskarStark modified the milestones: 7.1, 7.2 Apr 28, 2024
@symfony symfony deleted a comment from carsonbot Apr 28, 2024
@OskarStark OskarStark requested a review from Nyholm April 28, 2024 09:12
@OskarStark OskarStark changed the title [Notifier] Allow to send image to Bluesky [Notifier][Bluesky] Allow to attach image Apr 29, 2024
@carsonbot carsonbot changed the title [Notifier][Bluesky] Allow to attach image [Notifier] [Bluesky] Allow to attach image May 6, 2024
Nyholm
Nyholm reviewed May 6, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Well done. Just some minor comments

Nyholm
Nyholm approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@fabpot
Copy link
Member

fabpot commented May 21, 2024

Thank you @jdecool.

@fabpot fabpot merged commit 5ef34a4 into symfony:7.2 May 21, 2024
2 of 10 checks passed
@fabpot fabpot mentioned this pull request May 21, 2024
Closed
@xabbuh xabbuh mentioned this pull request May 24, 2024
Merged
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
6 participants
@jdecool @carsonbot @fabpot @nicolas-grekas @OskarStark @Nyholm