Skip to content

[ExpressionLanguage] Support non-existent names when followed by null coalescing #54757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

[ExpressionLanguage] Support non-existent names when followed by null coalescing #54757

merged 1 commit into from
May 31, 2024

Conversation

adamkiss
Copy link
Contributor

@adamkiss adamkiss commented Apr 28, 2024 •
edited by OskarStark
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Issues Fix #54359
License MIT

This PR allows for null coalescing nonexistent names (nonexistent ?? 123) in expressions by introducing new type of node NullCoalescedNameNode, which compiles to $nonexistent ?? null, so it subsequently evaluates to null and the null coalescing takes over then.

Edit: feature/bug is questionable, because I half-consider it a bug, since it's one of the examples in the docs, despite my original issue being closed as "expected", and the docs issue marked resolved despite this use case throwing while existing names resolving to null pass.

@carsonbot carsonbot added this to the 7.1 milestone Apr 28, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark modified the milestones: 7.1, 7.2 Apr 29, 2024
@OskarStark
Copy link
Contributor

To me this a new feature, please add an entry in the changeling for 7.2 section, as we are in feature freeze for 7.1, thanks

@adamkiss
Copy link
Contributor Author

To me this a new feature, please add an entry in the changeling for 7.2 section, as we are in feature freeze for 7.1, thanks

Shame about the feature freeze. will do.

@xabbuh xabbuh added the Feature label May 15, 2024
@fabpot fabpot force-pushed the feat-null-coalescing-nonexistent-names branch from 3a3dfdd to 3c620dc Compare May 31, 2024 06:30
@fabpot
Copy link
Member

fabpot commented May 31, 2024

Thank you @adamkiss.

@fabpot fabpot merged commit e8bd4f1 into symfony:7.2 May 31, 2024
3 of 10 checks passed
@fabpot fabpot mentioned this pull request May 31, 2024
Closed
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
ExpressionLanguage Feature Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[Expression Language] Null coalescing operator doesn't work?
6 participants
@adamkiss @carsonbot @OskarStark @fabpot @nicolas-grekas @xabbuh