Skip to content

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 29, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #53488
License MIT

additionally to fixing #53488 the model_type option is also renamed to input to be in line with other core form types (namely DateIntervalType, DateTimeType, DateType, NumberType, TimeType, TimezoneType and WeekType)

@xabbuh xabbuh requested a review from yceruto as a code owner April 29, 2024 13:52
@carsonbot carsonbot added this to the 7.1 milestone Apr 29, 2024
@fabpot fabpot added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 29, 2024
@nicolas-grekas
Copy link
Member

/cc @garak in case you would have a look.

@fabpot
Copy link
Member

fabpot commented May 1, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 29b00c2 into symfony:7.1 May 1, 2024
@xabbuh xabbuh deleted the issue-53488 branch May 1, 2024 16:33
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request May 2, 2024
This PR was merged into the 7.1 branch.

Discussion
----------

[Form] rename the model_type option to input

see symfony/symfony#54770

Commits
-------

a209c57 rename the model_type option to input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form] Issue with some code in MoneyType
6 participants