Skip to content

[TwigBundle] Fix deprecation warnings about base_template_class #54810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 2, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Follows #54657
License MIT

Since #54657, TwigBundle uses its own deprecated option in non-legacy tests. This PR fixes this by testing that option and the triggered deprecation message in a separate test.

@derrabus derrabus requested a review from yceruto as a code owner May 2, 2024 11:15
@carsonbot carsonbot added this to the 7.1 milestone May 2, 2024
@derrabus derrabus force-pushed the bugfix/base-template-class branch from 39095c8 to 1db27de Compare May 2, 2024 11:17
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit ef54646 into symfony:7.1 May 2, 2024
@derrabus derrabus deleted the bugfix/base-template-class branch May 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants