Skip to content

[Serializer] Rework XmlEncoderTest #54819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2024
Merged

[Serializer] Rework XmlEncoderTest #54819

merged 1 commit into from
Aug 3, 2024

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented May 2, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

I moved to use a data provider instead of extra test methods.

Would you accept this PR?
If yes, I will finish it

@OskarStark OskarStark self-assigned this May 2, 2024
@OskarStark OskarStark requested a review from dunglas as a code owner May 2, 2024 12:43
@carsonbot carsonbot added this to the 7.1 milestone May 2, 2024
@alexandre-daubois
Copy link
Member

That's nice! If this get accepted, don't forget to declare your new data providers static, a few ones are missing in the current codebase and will be fixed here #54824 🙂

@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
fabpot
fabpot requested changes May 31, 2024
View reviewed changes
mtarld
mtarld approved these changes Jul 12, 2024
View reviewed changes
@OskarStark OskarStark force-pushed the rework-xml-encoder-test branch 2 times, most recently from e556db4 to 058a54e Compare July 13, 2024 07:59
@OskarStark
Copy link
Contributor Author

Ready to merge from my side

@OskarStark OskarStark requested a review from fabpot July 13, 2024 07:59
@OskarStark OskarStark force-pushed the rework-xml-encoder-test branch from 058a54e to 3885de2 Compare July 18, 2024 20:32
@OskarStark OskarStark requested review from derrabus and xabbuh July 18, 2024 20:32
xabbuh
xabbuh reviewed Jul 19, 2024
View reviewed changes
@OskarStark OskarStark force-pushed the rework-xml-encoder-test branch from 24aa772 to 0e1de21 Compare July 26, 2024 12:52
@OskarStark
Copy link
Contributor Author

Rebased

@OskarStark OskarStark force-pushed the rework-xml-encoder-test branch from 0e1de21 to 074e3f3 Compare August 2, 2024 19:08
@OskarStark
Copy link
Contributor Author

Rebased

@fabpot fabpot force-pushed the rework-xml-encoder-test branch from 074e3f3 to 1cc89eb Compare August 3, 2024 09:05
@fabpot
Copy link
Member

fabpot commented Aug 3, 2024

Thank you @OskarStark.

@fabpot fabpot merged commit cf69feb into symfony:7.2 Aug 3, 2024
9 of 10 checks passed
@OskarStark OskarStark deleted the rework-xml-encoder-test branch August 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@fabpot fabpot fabpot approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@derrabus derrabus Awaiting requested review from derrabus

Assignees

@OskarStark OskarStark

Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
6 participants
@OskarStark @alexandre-daubois @fabpot @xabbuh @mtarld @carsonbot