-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Stopwatch] Add ROOT
constant to make it easier to reference
#54854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
ROOT
constant to make it easier to reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 7.2
What about if we also add a method named |
@xabbuh Updated as requested. |
Thank you @hacfi. |
…h a missing section
…fetch a mis… (Alex Niedre) This PR was merged into the 7.2 branch. Discussion ---------- [Stopwatch] bug #54854 undefined key error when trying to fetch a mis… | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? |no | Deprecations? |no | Issues | Fix #54854 | License | MIT A minor bug was introduced in the related referenced issue which caused an unidentified key exception to trigger when referencing a section that was missing. Reproduced here, as an example: https://3v4l.org/OFFLB This MR addresses that and adds a simple test to prevent the same mistake in the future. Commits ------- c3cf577 bug #54854 [Stopwatch] undefined key error when trying to fetch a missing section
* 7.2: [SecurityBundle] Do not replace authenticators service by their traceable version [Finder] Fix using `==` as default operator in `DateComparator` bug #54854 [Stopwatch] undefined key error when trying to fetch a missing section [HttpFoundation] Avoid mime type guess with temp files in `BinaryFileResponse` choose the correctly cased class name for the MariaDB platform
* upstream/7.3: [SecurityBundle] Do not replace authenticators service by their traceable version reject URLs containing whitespaces [Finder] Fix using `==` as default operator in `DateComparator` Update validators.fa.xlf the "max" option can be zero [PropertyInfo] Remove `@internal` directives to allow extensions with no static-analysis errors [TypeInfo] Fix PHPDoc resolving of union with mixed [Security/Csrf] Trust "Referer" at the same level as "Origin" bug symfony#54854 [Stopwatch] undefined key error when trying to fetch a missing section [HttpClient] Fix a typo in NoPrivateNetworkHttpClient [HttpFoundation] Avoid mime type guess with temp files in `BinaryFileResponse` choose the correctly cased class name for the MariaDB platform fix test method parameter names
Just an DX improvement so you can reference the root section with
$stopwatch->getSectionEvents(Stopwatch::ROOT)
instead of$stopwatch->getSectionEvents('__root__')
.