BicValidator add strict mode to validate bics in strict mode #54879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about adding a |
c460395 to
1b7bc67
Compare
maxbeckers
commented
May 13, 2024
| // should contain uppercase characters only | ||
| if (strtoupper($canonicalize) !== $canonicalize) { | ||
| // should contain uppercase characters only in strict mode | ||
| if (Bic::VALIDATION_MODE_STRICT === $constraint->mode && strtoupper($canonicalize) !== $canonicalize) { |
There was a problem hiding this comment.
@xabbuh I changed it now to mode, the way that was also done in the email validator, because i need id here for the check. With the normalizer way i wouldn't know to check this or not.
1b7bc67 to
a28b5e6
Compare
|
Another way would be to always uppercase the value, right? |
|
@fabpot exactly. But this could break other applications when the application trusts,that the input is always validated to be upper case. Or do you mean to always manipulate the input to go ahead with upper case? I would not recommend to change/manipulate the input in a validator at least without having a solution to change the behavior as a developer. |
fabpot
approved these changes
Jun 3, 2024
|
Thank you @maxbeckers. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a strict mode for bic validation (default strict, behavior before the pr is strict). But it is possible to set strict to
falseto allow lowercase input.I'll add it to the docs when this PR is merged.