Skip to content

[Serializer] Fix CurrentType for missing property #54913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

[Serializer] Fix CurrentType for missing property #54913

merged 1 commit into from
May 16, 2024

Conversation

ElisDN
Copy link
Contributor

@ElisDN ElisDN commented May 13, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

If requested data does not contain any property:

class A {
    function __construct(string $a) {}
}

try {
    $a = $serializer->deserialize('{}', A::class, 'json');
} catch (NotNormalizableValueException $e) {
    var_dump($e->getMessage());       // "Failed to create object because class misses the 'a' property."
    var_dump($e->getPath());          // "a"
    var_dump($e->getExpectedTypes()); // ["string"]
    var_dump($e->getCurrentType());   // "array"
}

then getCurrentType returns incorrect "array" value instead of expected "null" value.

@ElisDN ElisDN requested a review from dunglas as a code owner May 13, 2024 17:07
@carsonbot carsonbot added this to the 5.4 milestone May 13, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

xabbuh
xabbuh reviewed May 15, 2024
View reviewed changes
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -418,7 +418,7 @@ protected function instantiateObject(array &$data, string $class, array &$contex

$exception = NotNormalizableValueException::createForUnexpectedDataType(
sprintf('Failed to create object because the class misses the "%s" property.', $constructorParameter->name),
$data,
null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be $parameterData instead?

Copy link
Contributor Author

@ElisDN ElisDN May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is $parameterData = $data[$key] statement in cases above. But in this case (with missing parameter) the $data[$key] value does not exist and $parameterData will be empty too.

@nicolas-grekas
Copy link
Member

Thank you @ElisDN.

@nicolas-grekas nicolas-grekas merged commit a03ad0e into symfony:5.4 May 16, 2024
7 of 12 checks passed
@fabpot fabpot mentioned this pull request May 17, 2024
Merged
@ElisDN ElisDN deleted the fix_missing_property_ branch May 17, 2024 17:15
This was referenced Jun 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ElisDN @carsonbot @nicolas-grekas @xabbuh