[TwigBundle] added support for Twig namespaced paths (Twig 1.10) #5660
Conversation
In a template, you can now use native Twig template names, instead of
the Symfony ones:
Before (still works):
{% extends "AcmeDemoBundle::layout.html.twig" %}
{% include "AcmeDemoBundle:Foo:bar.html.twig" %}
After:
{% extends "@AcmeDemo/layout.html.twig" %}
{% include "@AcmeDemo/Foo/bar.html.twig" %}
Using native template names is also faster.
The only drawback is that the new notation looks similar to the way we
locate resources in Symfony, which would be
@AcmeDemoBundle/Resources/views/Foo/bar.html.twig. We could have used
the same notation, but it is rather verbose (and by the way, using this
notation did not work anyway in templates).
|
I forgot to mention why I'd like to include this change besides performance: this would allow to share templates between a project using the Symfony2 full-stack framework and any other project using Twig. |
|
👍 Will the old notation be deprecated at some point? |
|
@fabpot does it still support overwriting templates ? |
| private function addTwigPath($twigLoaderDefinition, $dir, $bundle) | ||
| { | ||
| $name = $bundle; | ||
| if ('Bundle' === substr($name, -6)) { |
There was a problem hiding this comment.
why removing Bundle ? this is not consistent with the way the @ notation is done elsewhere
There was a problem hiding this comment.
We are not consistent anyway as we go to Resources/views/ when using the location notation. So, it was done for three main reasons: trying to be as far as possible as the current notation to avoid confusion (or not), removing something that is, by convention, always present anyway, and more importantly trying to be more agnostic for when the templates are used outside of the full-stack framework.
Now, I'm open to any suggestion and if the majority think we need/can keep the bundle suffix, that would fine for me as well.
This PR was merged into the master branch. Commits ------- 5c809d8 [TwigBundle] added support for Twig namespaced paths (Twig 1.10) Discussion ---------- [TwigBundle] added support for Twig namespaced paths (Twig 1.10) In a template, you can now use native Twig template names, instead of the Symfony ones: Before (still works): {% extends "AcmeDemoBundle::layout.html.twig" %} {% include "AcmeDemoBundle:Foo:bar.html.twig" %} After: {% extends "@AcmeDemo/layout.html.twig" %} {% include "@AcmeDemo/Foo/bar.html.twig" %} Using native template names is also faster. The only drawback is that the new notation looks similar to the way we locate resources in Symfony, which would be `@AcmeDemoBundle/Resources/views/Foo/bar.html.twig`. We could have used the same notation, but it is rather verbose (and by the way, using this notation did not work anyway in templates). TODO: update documentation --------------------------------------------------------------------------- by fabpot at 2012-10-03T13:36:56Z I forgot to mention why I'd like to include this change besides performance: this would allow to share templates between a project using the Symfony2 full-stack framework and any other project using Twig. --------------------------------------------------------------------------- by henrikbjorn at 2012-10-03T13:50:48Z :+1: Will the old notation be deprecated at some point? --------------------------------------------------------------------------- by stof at 2012-10-03T14:29:50Z @fabpot does it still support overwriting templates ?
|
What's the reason for not also supporting this syntax in other parts of the framework, such as the controller? return $this->renderView('@AcmeDemo/Foo/bar.html.twig', array(...)); |
|
ref #6919 |
In a template, you can now use native Twig template names, instead of
the Symfony ones:
Before (still works):
After:
Using native template names is also faster.
The only drawback is that the new notation looks similar to the way we
locate resources in Symfony, which would be
@AcmeDemoBundle/Resources/views/Foo/bar.html.twig. We could have usedthe same notation, but it is rather verbose (and by the way, using this
notation did not work anyway in templates).
TODO: update documentation