[2.1] Exclude tests from zips via gitattributes #5674
Conversation
This PR was merged into the 2.1 branch. Commits ------- 462dddf [2.1] Exclude tests from zips via gitattributes Discussion ---------- [2.1] Exclude tests from zips via gitattributes See also: [Composer - Light-weight distribution packages](http://getcomposer.org/doc/02-libraries.md#light-weight-distribution-packages).
|
why not ignore .travis.yml at symfony root as you recommend in your link ? |
|
It's not really worth it for the main package. If we exclude anything, we should also exclude the tests. And AFAIK we would have to list all of the full paths for that which is a maintenance nightmare. The |
|
ok thanks |
|
@igorw This is not working for me. I have to put and |
|
The thing is, this worked for me locally with |
|
I have contacted GitHub to see if they can make it consistent. |
|
@igorw What is your git version ? I was not talking about Github but about my local testing |
|
Ah, maybe that's new then. |
|
I'm using 1.7.11 |
|
For the record, GitHub have updated their git version and it is now working as intended. |
|
I think this is a mistake. This way I have to install with |
|
Same as @marijn, tests are part of the documentation, and have proved more than useful to understand how internals are working. Also I like to run the tests when puttin my application on production, just to ensure that my server environnement doesn't break them. |
|
reverted |
* 2.1: [Yaml] fixed default value Added Yaml\Dumper::setIndentation() method to allow a custom indentation level of nested nodes. added a way to enable/disable object support when parsing/dumping added a way to enable/disable PHP support when parsing a YAML input via Yaml::parse() fixed CS [Process] Fix docblocks, remove `return` from `PhpProcess#start()` as parent returns nothing, cleaned up `ExecutableFinder` fixes a bug when output/error output contains a % character [Console] fixed input bug when the value of an option is empty (closes #6649, closes #6689) [Profiler] [Redis] Fix sort of profiler rows. Fix version_compare() calls for PHP 5.5. Removed underscores from test method names to be consistent with other components. [Process] In edge cases `getcwd()` can return `false`, then `proc_open()` should get `null` to use default value (the working dir of the current PHP process) Fix version_compare() calls for PHP 5.5. Handle the deprecation of IntlDateFormatter::setTimeZoneId() in PHP 5.5. removed the .gitattributes files (closes #6605, reverts #5674) [HttpKernel] Clarify misleading comment in ExceptionListener Conflicts: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_style.html.twig src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php src/Symfony/Component/Form/Tests/Util/PropertyPathTest.php src/Symfony/Component/HttpKernel/Profiler/RedisProfilerStorage.php src/Symfony/Component/Process/Process.php
|
I was directed here from fabpot/Twig#2 From @marijn
From @clemherreman
If your goal is running tests (developing Symfonty/Twig), a git clone be more appropriate. Which will continue to provide all the files. If your goal is reading documentation, the online documentation makes more sense than reading the raw documentation. http://twig.sensiolabs.org/documentation If the documentation is insufficient, well that seems like a different bug/issue. FWIW, I use Twig as a library (without Symfony) and downloading/deploying these extra bits across multiple servers is costing me bandwidth and time. Especially when you consider Twig is just one of many third party libraries I use. I'd prefer to download just the code when installing through compser. Deploying the documentation makes no sense. Deploying the tests make no sense. If I want to read documentation and tests, there are still plenty of avenues to do just that. |
|
@jdufresne see #6605 for more arguments. |
|
So Developer environments should indeed use I do not think its nice to force everyone to download overhead data just so some people can run tests without using Because of this, the .gitattributes is a good idea. |
|
+1 to @rdohms comment |
…symfony#5674)" This reverts commit b33d5bc.
* 2.1: [Yaml] fixed default value Added Yaml\Dumper::setIndentation() method to allow a custom indentation level of nested nodes. added a way to enable/disable object support when parsing/dumping added a way to enable/disable PHP support when parsing a YAML input via Yaml::parse() fixed CS [Process] Fix docblocks, remove `return` from `PhpProcess#start()` as parent returns nothing, cleaned up `ExecutableFinder` fixes a bug when output/error output contains a % character [Console] fixed input bug when the value of an option is empty (closes symfony#6649, closes symfony#6689) [Profiler] [Redis] Fix sort of profiler rows. Fix version_compare() calls for PHP 5.5. Removed underscores from test method names to be consistent with other components. [Process] In edge cases `getcwd()` can return `false`, then `proc_open()` should get `null` to use default value (the working dir of the current PHP process) Fix version_compare() calls for PHP 5.5. Handle the deprecation of IntlDateFormatter::setTimeZoneId() in PHP 5.5. removed the .gitattributes files (closes symfony#6605, reverts symfony#5674) [HttpKernel] Clarify misleading comment in ExceptionListener Conflicts: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_style.html.twig src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php src/Symfony/Component/Form/Tests/Util/PropertyPathTest.php src/Symfony/Component/HttpKernel/Profiler/RedisProfilerStorage.php src/Symfony/Component/Process/Process.php
See also: Composer - Light-weight distribution packages.