adds two convenience methods for optional configuration sections #5688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Looks good. Can you update the documentation as well and add a note in the component CHANGELOG? Thanks. |
schmittjoh
added a commit
to schmittjoh/symfony-docs
that referenced
this pull request
Oct 6, 2012
|
done |
| return $this; | ||
| } | ||
|
|
||
| public function canBeDisabled() |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2012
This PR was merged into the master branch. Commits ------- 36bbaf3 added entry to changelog 0187a1a adds two convenience methods for optional configuration sections Discussion ---------- adds two convenience methods for optional configuration sections This adds two convenience methods which safes some typing for optional configuration. I have updated the FrameworkConfiguration to use these methods; the behavior is equivalent. --------------------------------------------------------------------------- by sstok at 2012-10-06T12:21:09Z :+1: --------------------------------------------------------------------------- by fabpot at 2012-10-06T12:32:10Z Looks good. Can you update the documentation as well and add a note in the component CHANGELOG? Thanks. --------------------------------------------------------------------------- by schmittjoh at 2012-10-06T14:22:35Z done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two convenience methods which safes some typing for optional configuration.
I have updated the FrameworkConfiguration to use these methods; the behavior is equivalent.