Skip to content

[POC] Content negotiation implementation. #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from
Closed

[POC] Content negotiation implementation. #5711

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
efcbab1
[HttpFoundation] Added content negociation headers support to request.
jfsimon Oct 9, 2012
5fb2601
[HttpFoundation] Added tests.
jfsimon Oct 9, 2012
020914b
[routing] Added acceptances to request context.
jfsimon Oct 10, 2012
8c02e8a
[http-foundation] Moved accept headers parsing to dedicated class.
jfsimon Oct 10, 2012
532720a
[routing] Added negotiation to UrlMatcher.
jfsimon Oct 11, 2012
b01c9d5
[http-foundation] Fixed error.
jfsimon Oct 11, 2012
88c5761
[http-foundation] Repaired broken tests.
jfsimon Oct 11, 2012
aeaeb02
[routing] Fixed content negotiation basic implementation.
jfsimon Oct 11, 2012
cf6ff20
[http-kernel] Added 406 http exception handler.
jfsimon Oct 12, 2012
94e2df2
[routing] Added '_negotiation' parameter.
jfsimon Oct 12, 2012
215dcbe
[http-foundation] Fixed docblock.
jfsimon Oct 12, 2012
f7651ef
Cleaned code.
jfsimon Oct 12, 2012
c98fb8f
[http-kernel] Added content negotiation listener.
jfsimon Oct 12, 2012
88e1d39
[framework-bundle] Registered content negotiation listener as service.
jfsimon Oct 12, 2012
875ba49
[routing] Removed content negotiation logic from routing.
jfsimon Oct 13, 2012
5504c20
[http-foundation] Added negotiation foundation.
jfsimon Oct 13, 2012
472d587
Fixed CS.
jfsimon Oct 13, 2012
f926cbb
[http-foundation] Added Vary header support.
jfsimon Oct 13, 2012
9d310df
[routing] Removed handlers from context.
jfsimon Oct 13, 2012
cf73c2c
[http-kernel] Reimplemented basic negotiation.
jfsimon Oct 13, 2012
6a39b9b
Fixed various errors.
jfsimon Oct 14, 2012
790562d
[framework-bundle] Updated content_negotiation_listener definition.
jfsimon Oct 14, 2012
0773c3c
[http-kernel] Fixed listener.
jfsimon Oct 14, 2012
13cf246
[http-foundation] Added base content class.
jfsimon Oct 14, 2012
6ecf6bb
[routing] Removed wrong code & added simple negotiation process to ur…
jfsimon Oct 14, 2012
e23df7c
[http-foundation] Added visibility to interface methods.
jfsimon Oct 14, 2012
d3166b4
[http-kernel] Removed previously introduced negotiation.
jfsimon Oct 14, 2012
936ff9c
[routing] Updated matcher negotiator implementation.
jfsimon Oct 14, 2012
d570a59
[http-kernel] Added matcher negotiator builder.
jfsimon Oct 14, 2012
f98203e
Fixed errors & bad implementations.
jfsimon Oct 14, 2012
94fce2b
Fixed typo.
jfsimon Oct 17, 2012
2de69fe
Improved accept header parser.
jfsimon Oct 17, 2012
4071d7e
Fixed CS.
jfsimon Oct 17, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed typo.
  • Loading branch information
@jfsimon
jfsimon committed Oct 17, 2012
commit 94fce2b8f6e444ff68a7dde9753944cb7cfeffa7
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Negotiation/NegotiatorInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function addQualifier(QualifierInterface $qualifier);
/**
* Adds a document to qualify.
*
* @param ContentInterface $variant
* @param ContentInterface $content
*/
public function addContent(ContentInterface $content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or this must be $variant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's $content :)


Expand Down